Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on [vm] Streamline Zones. #47399

Closed
alexmarkov opened this issue Oct 6, 2021 · 0 comments
Closed

Failures on [vm] Streamline Zones. #47399

alexmarkov opened this issue Oct 6, 2021 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on [vm] Streamline Zones..

The tests

vm/cc/AllocateZone Fail (expected Pass)

are failing on configurations

dartk-mac-debug-x64
dartk-mac-release-x64
--- Command "run_vm_unittest" (took 58ms):
DART_CONFIGURATION=DebugX64 xcodebuild/DebugX64/run_vm_tests --dfe=/opt/s/w/ir/xcodebuild/DebugX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags AllocateZone

exit code:
255

stdout:
Running test: AllocateZone
Done: AllocateZone

stderr:
*** Starting a new Stack zone 0x7ffee30d0fd8(0x7fa77680e600)
*** Starting a new Api zone 0x7fa77680bc30(0x7fa77680bc30)
*** Starting a new Stack zone 0x7ffee30d0f08(0x7fa77680ae00)
*** Expanding zone 0x7fa77680ae00
Zone(0x7fa77680ae00, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Starting a new Stack zone 0x7ffee30d0a50(0x7fa776807e00)
*** Expanding zone 0x7fa776807e00
Zone(0x7fa776807e00, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Deleting Stack zone 0x7ffee30d0a50(0x7fa776807e00)
Zone(0x7fa776807e00, segments: 65664, scoped_handles: 1024, zone_handles: 0, total: 66688)
*** Deleting Stack zone 0x7ffee30d0f08(0x7fa77680ae00)
Zone(0x7fa77680ae00, segments: 65664, scoped_handles: 289792, zone_handles: 1024, total: 356480)
*** Expanding zone 0x7fa77680bc30
Zone(0x7fa77680bc30, segments: 128, scoped_handles: 1024, zone_handles: 1024, total: 2176)
*** Deleting Stack zone 0x7ffee30d0fd8(0x7fa77680e600)
Zone(0x7fa77680e600, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Starting a new Stack zone 0x7ffee30d1198(0x7fa775815800)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 65664, scoped_handles: 1024, zone_handles: 0, total: 66688)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 1118336, scoped_handles: 1024, zone_handles: 0, total: 1119360)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 2171008, scoped_handles: 1024, zone_handles: 0, total: 2172032)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 3223680, scoped_handles: 1024, zone_handles: 0, total: 3224704)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 4276352, scoped_handles: 1024, zone_handles: 0, total: 4277376)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 5329024, scoped_handles: 1024, zone_handles: 0, total: 5330048)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 6381696, scoped_handles: 1024, zone_handles: 0, total: 6382720)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 7434368, scoped_handles: 1024, zone_handles: 0, total: 7435392)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 8487040, scoped_handles: 1024, zone_handles: 0, total: 8488064)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 9539712, scoped_handles: 1024, zone_handles: 0, total: 9540736)
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 10592384, scoped_handles: 1024, zone_handles: 0, total: 10593408)
../../runtime/vm/zone_test.cc: 54: error: expected: 10551328 <= 8117320
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 10662016, scoped_handles: 1024, zone_handles: 0, total: 10663040)
../../runtime/vm/zone_test.cc: 61: error: expected: 10616848 <= 8117320
*** Expanding zone 0x7fa775815800
Zone(0x7fa775815800, segments: 10731648, scoped_handles: 1024, zone_handles: 0, total: 10732672)
../../runtime/vm/zone_test.cc: 68: error: expected: 10682392 <= 8117320
*** Deleting Stack zone 0x7ffee30d1198(0x7fa775815800)
Zone(0x7fa775815800, segments: 10801280, scoped_handles: 1024, zone_handles: 0, total: 10802304)
*** Starting a new Stack zone 0x7ffee30d10f8(0x7fa775815800)
*** Deleting Stack zone 0x7ffee30d10f8(0x7fa775815800)
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Starting a new Stack zone 0x7ffee30d1070(0x7fa775815800)
*** Deleting Stack zone 0x7ffee30d1070(0x7fa775815800)
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Starting a new Stack zone 0x7ffee30d0f88(0x7fa775815800)
*** Deleting Stack zone 0x7ffee30d0f88(0x7fa775815800)
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Deleting Api zone 0x7fa77680bc30(0x7fa77680bc30)
Zone(0x7fa77680bc30, segments: 128, scoped_handles: 1024, zone_handles: 1024, total: 2176)
*** Starting a new Stack zone 0x7ffee30d11d0(0x7fa775815800)
*** Deleting Stack zone 0x7ffee30d11d0(0x7fa775815800)
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)
*** Starting a new Stack zone 0x7ffee30d10e8(0x7fa775815800)
*** Deleting Stack zone 0x7ffee30d10e8(0x7fa775815800)
Zone(0x7fa775815800, segments: 128, scoped_handles: 1024, zone_handles: 0, total: 1152)

--- Re-run this test:
python3 tools/test.py -n dartk-mac-debug-x64 vm/cc/AllocateZone

https://dart-ci.appspot.com/log/vm-kernel-mac-debug-x64/dartk-mac-debug-x64/14114/vm/cc/AllocateZone

@rmacnak-google Could you please take a look?

@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Oct 6, 2021
copybara-service bot pushed a commit that referenced this issue Oct 14, 2021
Fix imprecision in Zone::SizeInBytes that was finally noticed by vm/cc/AllocateZone because the size of the initial inline buffer changed.

TEST=ci
Bug: #47399
Change-Id: I152d24d03a59b21267a9a24e5d929b51af57af71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215980
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@a-siva a-siva closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

2 participants