Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Super-Initializer Parameters language feature in the CFE #47525

Closed
Tracked by #48055
chloestefantsova opened this issue Oct 21, 2021 · 1 comment
Closed
Tracked by #48055

Implement Super-Initializer Parameters language feature in the CFE #47525

chloestefantsova opened this issue Oct 21, 2021 · 1 comment
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool)

Comments

@chloestefantsova
Copy link
Contributor

This issue is for implementing the Super-Initializer Prameters language feature in the CFE and referencing it in the related CLs.
@chloestefantsova chloestefantsova added area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool) labels Oct 21, 2021
@chloestefantsova chloestefantsova self-assigned this Oct 21, 2021
copybara-service bot pushed a commit that referenced this issue Oct 21, 2021
Add "super-parameters" experiment flag
29e0c5e 
Part of #47525.

Change-Id: If7bf6f39b9b3ade1769f158ea1ca45515f859a2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217640
Auto-Submit: Chloe Stefantsova <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 19, 2021
@chloestefantsova
[parser][analyzer][cfe] Add parsing support for super-parameters
46cf1b9 
Part of #47525

Change-Id: I7b824e5e3fc9dbb2c6416dfd15df274037a8e9e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219521
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@chloestefantsova chloestefantsova changed the title Implement Super-Initializer Parameters language feature Implement Super-Initializer Parameters language feature in the CFE Dec 6, 2021
copybara-service bot pushed a commit that referenced this issue Dec 6, 2021
@chloestefantsova
[parser] Add support for typed super-initializer parameters
fc9f7e3 
Part of #47525

Closes #47741

Bug: #47741
Change-Id: I0558b33aa43cc73e67ca0d17bd5c8ec1afdc526f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221634
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 7, 2021
@chloestefantsova
Revert "[parser] Add support for typed super-initializer parameters"
7359264 
This reverts commit fc9f7e3.

Reason for revert: breakages in ternary operators involving super access.

Original change's description:
> [parser] Add support for typed super-initializer parameters
>
> Part of #47525
>
> Closes #47741
>
> Bug: #47741
> Change-Id: I0558b33aa43cc73e67ca0d17bd5c8ec1afdc526f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221634
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: #47741
Change-Id: I565faadeb0776a089853dc2264af50b069e16056
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222301
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 10, 2021
@chloestefantsova
[cfe] Handle the simple case of positional super-parameters
b8c336f 
Part of #47525

Change-Id: Ia16012dbc00ea5350ad115cc720758404585d14d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222460
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 13, 2021
@chloestefantsova
[cfe] Add some of the compile-time errors for super parameters
843583f 
Part of #47525

Change-Id: Ic0ad44656f6b5f6fa56f8c130e3e44b8729a9659
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223160
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 14, 2021
@chloestefantsova
[cfe] Handle synthesized super initializers in super-parameters
2f7a1ce 
Part of #47525

Change-Id: I768dce70465a77a94609af03b21c64d4bf4a1386
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223800
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 29, 2021
@chloestefantsova
[cfe] Add initial inference support for super-parameters
1b58c83 
Part of #47525

Change-Id: I780f1aa323d740eda7d1e91ebab12fa123a9a32f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223580
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@chloestefantsova chloestefantsova mentioned this issue Jan 5, 2022
Closed
@devoncarew devoncarew mentioned this issue Jan 5, 2022
Closed
23 tasks
@alexmarkov alexmarkov mentioned this issue Jan 13, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jan 17, 2022
@chloestefantsova
[cfe] Correct indices in default value cloning for super-parameters
5db9147 
Part of #47525

Closes #48142

Change-Id: Iad39ced9458993c369c7b4696eeae49cd06f84b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228204
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 21, 2022
@chloestefantsova
[cfe] Disentangle type inference and default value copying in super-p…
76c38fb 
…arameters

Part of #47525

Change-Id: Ia8f14aa5995f50719bc95d8b26c3bd5a40d6f967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229148
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 10, 2022
@chloestefantsova
[cfe] Pass pre-parsed initializers to resolve super-initizer target
6939628 
Closes #48286

Part of #47525

Change-Id: Ie8816c407b7ab1b6510e5cf139b88c33728f55a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231948
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 23, 2022
@chloestefantsova
[cfe] Allow typed super parameters
c12238d 
Part of #47525

Closes #47741
Closes #48444
Closes #47951

Change-Id: If9aadd996414df5091fc667a7202aafa9a0213db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233889
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 4, 2022
@chloestefantsova
[cfe] Check types of super parameters for assignability
43840be 
The CL enables both the checks of the super parameter relative to the
corresponding parameter of the super constructor and the types of the
copied default values.

Part of #47525

Change-Id: I92dfa22c108bf07a69e1f8b5a210f6268ddfaa2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235080
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 21, 2022
@chloestefantsova
[cfe] Report an error on 'var' before a super parameter
b732254 
Part of #47525

Change-Id: I6f797231db362681c00a0fc5910a6d8b17960e1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237691
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 24, 2022
@chloestefantsova
[cfe] Report errors on super parameters not in a constructor
112f987 
Part of #47525

Change-Id: I9ac7f5a49c09755445b6b407af5abf1037cba2e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237687
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 29, 2022
@chloestefantsova
[cfe] Remove coercions for super parameters
61465fb 
Part of #47525

Change-Id: Iadb2f0125318edd73ab84e5b1a9cafae098ec618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239081
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 30, 2022
@chloestefantsova
[cfe] Add DillConstructorBuilder to super parameters inference
d5c9f08 
Part of #47525

Change-Id: If88bf24dffa79e214e49b5133ee8314bbdb53716
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239426
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 31, 2022
@chloestefantsova
Revert "[cfe] Remove coercions for super parameters"
1123958 
This reverts commit 61465fb.

Reason for revert: potential future Flutter breakages.

Original change's description:
> [cfe] Remove coercions for super parameters
>
> Part of #47525
>
> Change-Id: Iadb2f0125318edd73ab84e5b1a9cafae098ec618
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239081
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1f6321af1a3290f00920d056c68dfb9b68dd5e9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239423
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 31, 2022
@chloestefantsova
Reland "[cfe] Remove coercions for super parameters"
ac19f52 
This is a reland of commit 61465fb

Original change's description:
> [cfe] Remove coercions for super parameters
>
> Part of #47525
>
> Change-Id: Iadb2f0125318edd73ab84e5b1a9cafae098ec618
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239081
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

Change-Id: I57c9f4b541d8c655f6ec855a131801008195c213
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239428
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 31, 2022
@chloestefantsova
[cfe] Allow final super parameters
06bf357 
Closes #48714

Part of #47525

Change-Id: Ifa78ac0909c466fb3c9ec9cc5d850a09fa1ee650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239662
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
@chloestefantsova
Copy link
Contributor Author

This is considered implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. implementation Track the implementation of a specific feature (use on area-meta issue, not issues for each tool)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chloestefantsova