Failures on [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests

[alexmarkov]

There are new test failures on [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests.

The tests

standalone_2/io/platform_test RuntimeError (expected Pass)

are failing on configurations

dartkp-linux-release-simarm-crossword
dartkp-linux-release-x64
dartkp-obfuscate-linux-release-x64
dartkp-win-release-x64

/cc @mkustermann

[mkustermann]

This is an existing failure. It is just that the test itself went from being a multitest with .../0 and .../1 sub-tests to be a non-multitest. So it appears like a new failure but it isn't.

Looking at the test it's pretty obvious that it doesn't work in AOT:

test() {
  ...
  if (!Platform.isWindows) {
    Expect.isTrue(Platform.executable.endsWith('dart'));
    Expect.isTrue(Platform.resolvedExecutable.endsWith('dart'));
  } else {
    Expect.isTrue(Platform.executable.endsWith('dart.exe'));
    Expect.isTrue(Platform.resolvedExecutable.endsWith('dart.exe'));
  }
 ...
}
main() {
  ...
  test();
  ...
}

In AOT we Platform.executable will of course be dart_precompiled_runtime.

[alexmarkov]

Currently failing on the following configurations:

app_jitk-linux-debug-x64
app_jitk-linux-release-x64
dartk-linux-release-simarm
dartkp-linux-debug-x64
dartkp-linux-product-x64
dartkp-linux-release-simarm
dartkp-linux-release-simarm-crossword
dartkp-linux-release-simarm64
dartkp-linux-release-x64
dartkp-mac-release-simarm64
dartkp-obfuscate-linux-release-x64
dartkp-strong-linux-release-x64
dartkp-weak-asserts-linux-release-x64
dartkp-win-release-x64

[mkustermann]

Same testing infrastructure is probably responsible for this (old and new) failure:

The tests

vm/dart_2/spawn_shutdown_test Crash (expected Pass)

are failing on configurations

app_jitk-linux-product-x64

--- Command "app_jit" (took 04.000635s):
DART_CONFIGURATION=ProductX64 out/ProductX64/dart --snapshot=/b/s/w/ir/out/ProductX64/generated_compilations/app_jitk-linux-product-x64/runtime_tests_vm_dart_2_spawn_shutdown_test/out.jitsnapshot --snapshot-kind=app-jit --enable-asserts --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/runtime/tests/vm/dart_2/spawn_shutdown_test.dart

exit code:
-6

stdout:
Info: Compiling without sound null safety
Starting 50 workers...
Waiting for 0:00:02.000000 before exit...

stderr:
../../runtime/lib/isolate.cc: 745: error: Dart_RunLoopAsync() failed: There must not be an active api scope.. Please file a Dart VM bug report.

--- Re-run this test:
python3 tools/test.py -n app_jitk-linux-product-x64 vm/dart_2/spawn_shutdown_test

[mkustermann]

Uploaded cl/219520 to fix the test as well as a VM issue on the error path.

Both issues have been around for a long time and weren't actually caused by my change.

[mkustermann]

Both standalone_2/io/platform_test and vm/dart_2/spawn_shutdown_test are passing in all configuration now.