Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup support for old versions of package:dwds #48103

Closed
nshahan opened this issue Jan 8, 2022 · 1 comment
Closed

Cleanup support for old versions of package:dwds #48103

nshahan opened this issue Jan 8, 2022 · 1 comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P3 A lower priority bug or feature request web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented Jan 8, 2022

In the next major version of the Dart SDK (3.0.0) it should be safe to remove the backwards compatibility for versions of package:dwds older than v11.1.0.

This means we can completely remove the support for writing 'dart.developer.registerExtension' and 'dart.developer.postEvent' to the chrome debug console.

Newer versions of package:dwds already communicate these events through function hooks. See c83eeac.
@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P3 A lower priority bug or feature request labels Jan 8, 2022
copybara-service bot pushed a commit that referenced this issue Feb 3, 2022
@nshahan
[ddc] Update warning message with dwds version
e44af61 
Change-Id: I26b5393256506f4ca1773baea15e71bee4b54683
Issue: #48103
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226964
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
@nshahan
Copy link
Contributor Author

nshahan commented Jan 24, 2023

cc @elliette
Tracking the cleanup we briefly discussed on the DDC side. It turns out I actually already did the cleanup on the dwds side. 😆 dart-lang/webdev#1342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P3 A lower priority bug or feature request web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan