Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more actionable error message if inter-isolate message sends fail #48592

Closed
mkustermann opened this issue Mar 17, 2022 · 2 comments
Closed

Provide more actionable error message if inter-isolate message sends fail #48592

mkustermann opened this issue Mar 17, 2022 · 2 comments
Assignees
@aam
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate

Comments

@mkustermann
Copy link
Member

When a message send fails due to transitive closure referencing objects that are disallowed (e.g. NativeFieldWrapper subclasses) the error message atm is not actionable (see e.g. #48566)

@mraleph proposed to re-trace the object graph and possibly make the error message contain the path from root of object graph to the object that cannot be sent.

/cc @mit-mit @lrhn
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate labels Mar 17, 2022
@mkustermann mkustermann mentioned this issue Mar 17, 2022
Closed
@mkustermann
Copy link
Member Author

/cc @aam

@mkustermann
Copy link
Member Author

Users do run into this. It may be a big usability improvement to implement a retaining path to the NativeFieldWrapper.

See user report here

@simolus3 simolus3 mentioned this issue Jan 24, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Feb 23, 2023
@aam
[vm/isolates] Include retaining path into an illegal send argument ex…
4f30b5c 
…ception.

The exception contains retaining path that looks like this:
```
Invalid argument(s): Illegal argument in isolate message: (object extends NativeWrapper - Library:'dart:io' Class: _RandomAccessFileOpsImpl@14069316)
 <- Library:'dart:io' Class: _RandomAccessFile@14069316
 <- Library:'file:///vm/dart/isolates/send_unsupported_objects_test.dart' Class: SomeLog
 <- Library:'file:///vm/dart/isolates/send_unsupported_objects_test.dart' Class: SomeState
 <-  Class: Context
 <- Library:'dart:core' Class: _Closure@0150898

```

BUG=#51115
BUG=#48592
TEST=send_unsupported_objects_test

Change-Id: I022e693adccf43a7d2c95e1c7283fd7f210cf1d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280523
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
@aam aam closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aam aam

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @mkustermann