-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to dart analyze
for analyzing the Dart SDK libraries
#48959
Comments
Bug: #48959 Change-Id: I4c386f1f7c474c1ff809d15d597d3f8f2de0418a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243847 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
The new test that is added fails because it does not match the wording of the error message. It was not found on presubmit because the test pkg/dartdev/test/commands/analyze_test is flaky on all platforms except the new arm64 macos platform. This also points out that a flaky test is not useful any more to find new failures. |
I just was gardening the results feed again, and hit this issue, and tracked it down again, finding this issue I'd already filed. This is because the test was marked flaky on mac, and so when the flakiness expired after 100 failing runs, it showed up on the results feed. I went to the history, and didn't see the existing issue, because I didn't delete the configuration from the filtered search, which would have searched just on the name and found this issue. Instead, I debugged it again, and found the failing commit, and then found the comment on that commit. |
Would it be possible, given the path to a file or directory, to automatically detect that the path is inside of a checkout of the sdk repository and to not require the user to specify the path to a parent directory of the path being analyzed? As far as I know, analyzing files inside a a checkout of the sdk repository is the only use case we have for the |
Yes I think so.
+1 I think this should be filed as a separate request, since the support for the flag has landed. |
So, if we can identify the SDK repository, we can remove |
I would guess that is true. I don't really know the use case for the SDK test runner. |
As needed for #48457
This is currently supported via
dartanalyzer --dart-sdk=/Users/foo/src/dart-repo/sdk/sdk
for example.The text was updated successfully, but these errors were encountered: