Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package:markdown to latest published version (5.0.0+) in DEPS #48967

Closed
pq opened this issue May 5, 2022 · 11 comments
Closed

update package:markdown to latest published version (5.0.0+) in DEPS #48967

pq opened this issue May 5, 2022 · 11 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-task A well-defined stand-alone task

Comments

@pq
Copy link
Member

pq commented May 5, 2022

I tried to bump package:markdown but hit a snag with a failing internal test and had to revert (https://dart-review.googlesource.com/c/sdk/+/243800). The internal issue with details is b/231525859.

@srawlins : maybe you could take a look?

@pq pq added the area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. label May 5, 2022
@pq pq added the P2 A bug or feature request we're likely to work on label May 5, 2022
@pq pq changed the title bump markdown to 5.0.0+ update package:markdown to latest published version (5.0.0+) in DEPS May 5, 2022
copybara-service bot pushed a commit that referenced this issue May 5, 2022
This reverts commit a8e5b4b.

See breakage details in b/231525859.

Tracking issue to get this (re)-bumped:  #48967.


Change-Id: I4679901c67e65cf7e0f7ddb1f7e285effa1c9763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243800
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@srawlins
Copy link
Member

srawlins commented May 5, 2022

I would make this a P4; is there a reason it should be bumped soon?

@srawlins srawlins added the type-task A well-defined stand-alone task label May 5, 2022
@pq
Copy link
Member Author

pq commented May 5, 2022

Great question. I'm not sure how to assign priorities here and happy to defer to ecosystem folks. A down-side to not staying up to date is that it keeps all of the vended packages w/ dependencies on markdown on older versions (because in theory they should have compatible version constraints w/ what's in the SDK). Superficially, that affects pub scoring... More substantially I think it's just more tech debt.

I guess the question I would ask is why are we publishing versions of packages and not keeping them up to date in the SDK?

@srawlins
Copy link
Member

srawlins commented May 5, 2022

That all makes sense.

I guess the question I would ask is why are we publishing versions of packages and not keeping them up to date in the SDK?

Hmm, what do you mean? Like why don't we do it on the same day? I'm certainly not proposing that we don't update the package in the SDK. We should, some day, according to priorities.

@pq
Copy link
Member Author

pq commented May 5, 2022

Hmm, what do you mean? Like why don't we do it on the same day?

Great question. And another for the ecosystem team. It looks like markdown was published just over a month ago. Is that a long time? Dunno. Unacceptably long? That depends on how important we think it is which is why I'd be curious to get @devoncarew's take.

@natebosch
Copy link
Member

natebosch commented May 5, 2022

We should be syncing these packages to the SDK, and especially to google3, before we publish them.

https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#publishing-a-package

@natebosch
Copy link
Member

Publishing breaking changes which we can't yet accept in the SDK or google3 seems especially risky.

@srawlins srawlins added P3 A lower priority bug or feature request and removed P2 A bug or feature request we're likely to work on labels May 5, 2022
@srawlins
Copy link
Member

srawlins commented May 5, 2022

Thanks for the reminder, @natebosch I had forgotten that. I'll mark this P3.

@pq
Copy link
Member Author

pq commented May 18, 2022

@devoncarew
Copy link
Member

@pq, @srawlins - do you know if markdown is now sync'd past the commit that was causing issues in google3? I see the above CL landed, but there are still ~15 unsynced markdown commits.

@pq
Copy link
Member Author

pq commented Jun 1, 2022

I believe that bumping to 5.0.0 is what was causing the issues and we're past them. It should be safe to sync to latest now but @srawlins may know better.

@srawlins
Copy link
Member

srawlins commented Jun 2, 2022

Yep, should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-task A well-defined stand-alone task
Projects
None yet
Development

No branches or pull requests

4 participants