-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package:markdown to latest published version (5.0.0+) in DEPS #48967
Comments
This reverts commit a8e5b4b. See breakage details in b/231525859. Tracking issue to get this (re)-bumped: #48967. Change-Id: I4679901c67e65cf7e0f7ddb1f7e285effa1c9763 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243800 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
I would make this a P4; is there a reason it should be bumped soon? |
Great question. I'm not sure how to assign priorities here and happy to defer to ecosystem folks. A down-side to not staying up to date is that it keeps all of the vended packages w/ dependencies on markdown on older versions (because in theory they should have compatible version constraints w/ what's in the SDK). Superficially, that affects pub scoring... More substantially I think it's just more tech debt. I guess the question I would ask is why are we publishing versions of packages and not keeping them up to date in the SDK? |
That all makes sense.
Hmm, what do you mean? Like why don't we do it on the same day? I'm certainly not proposing that we don't update the package in the SDK. We should, some day, according to priorities. |
Great question. And another for the ecosystem team. It looks like markdown was published just over a month ago. Is that a long time? Dunno. Unacceptably long? That depends on how important we think it is which is why I'd be curious to get @devoncarew's take. |
We should be syncing these packages to the SDK, and especially to google3, before we publish them. https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#publishing-a-package |
Publishing breaking changes which we can't yet accept in the SDK or google3 seems especially risky. |
Thanks for the reminder, @natebosch I had forgotten that. I'll mark this P3. |
I believe that bumping to 5.0.0 is what was causing the issues and we're past them. It should be safe to sync to latest now but @srawlins may know better. |
Yep, should be. |
I tried to bump
package:markdown
but hit a snag with a failing internal test and had to revert (https://dart-review.googlesource.com/c/sdk/+/243800). The internal issue with details is b/231525859.@srawlins : maybe you could take a look?
The text was updated successfully, but these errors were encountered: