Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed memory utilization data in dump-info #49160

Open
sigmundch opened this issue Jun 1, 2022 · 0 comments
Open

embed memory utilization data in dump-info #49160

sigmundch opened this issue Jun 1, 2022 · 0 comments
Assignees
@Markzipan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js

Comments

@sigmundch
Copy link
Member

Now that dart2js fetches within the process how much RAM it uses, we'd like to include it in the data of dart2js_info.

It would also be helpful to add more details to both compile-time and RAM data to segment the data by phase (or a way to aggregate the data from multiple phases if that's possible). One challenge for this is to allow to aggregate the data across sequential steps (with serialization), but be cautious to not disturb caching data between phases (possibly by adding this data on the side on a separate file that is not consumed except for the dump-info aggregation process).
@a-siva a-siva added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jun 1, 2022
copybara-service bot pushed a commit that referenced this issue Jul 12, 2022
@Markzipan
[dart2js] Adding total program RAM usage to dump info's output
635a3bf 
See: #49160

This doesn't offer a phase-specific view of the ram usage nor aggregate ram usage across split phase compilation.

Change-Id: Ia1f781f9bd35b40048ac23fe103b8fee3b4da584
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250947
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Markzipan Markzipan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundch @Markzipan @a-siva