Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy dartanalyzer features not needed for automation #49537

Open
jcollins-g opened this issue Jul 27, 2022 · 0 comments
Open

Remove legacy dartanalyzer features not needed for automation #49537

jcollins-g opened this issue Jul 27, 2022 · 0 comments
Assignees
@jcollins-g
Labels
analyzer-command Issues with the command-line dartanalyzer tool analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. dart-cli-analyze Issues related to the 'dart analyze' tool P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Jul 27, 2022 •
edited
Loading

This issue follows up on #48457 for cleaning up unnecessary features in the analyzer_cli package to make it easier to maintain going forward. You can reference this issue in any requests to port dartanalyzer features to the Dart CLI or to retain them for SDK development purposes.

--options, while not strictly needed by the automation, will be retained until #49433 is supported by the regular dart CLI.

The following command line options are known to be used by the test_runner and other automation:

  • --batch
  • --dart-sdk
  • --packages
  • --use-analysis-driver-memory-byte-store
  • --use-cfe
  • --use-fasta-parser
@jcollins-g jcollins-g added dart-cli-analyze Issues related to the 'dart analyze' tool analyzer-command Issues with the command-line dartanalyzer tool analyzer-technical-debt P2 A bug or feature request we're likely to work on area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Jul 27, 2022
@jcollins-g jcollins-g self-assigned this Jul 27, 2022
copybara-service bot pushed a commit that referenced this issue Aug 3, 2022
@jcollins-g
Remove more unused analyzer_cli options for strong mode, implicit cas…
5ce344d 
…ts, implicit dynamic, and declaration-casts.

Bug: #49537
Change-Id: I57e41e1ab82c3486d90c858c400d073645f56b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252869
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Auto-Submit: Janice Collins <jcollins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcollins-g jcollins-g

Labels
analyzer-command Issues with the command-line dartanalyzer tool analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. dart-cli-analyze Issues related to the 'dart analyze' tool P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @jcollins-g