Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gardening] vm/cc/StoreReleaseLoadAcquire started timing out #50236

Closed
dcharkes opened this issue Oct 17, 2022 · 4 comments
Closed

[gardening] vm/cc/StoreReleaseLoadAcquire started timing out #50236

dcharkes opened this issue Oct 17, 2022 · 4 comments
Assignees
@dcharkes
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@dcharkes
Copy link
Contributor

There are new test failures on [dart2js] Migrate resolution_world_builder.dart...Bump emsdk revision (fix build for Windows on Arm).

The tests

vm/cc/StoreReleaseLoadAcquire Timeout (expected Pass)
vm/cc/StoreReleaseLoadAcquire1024 Timeout (expected Pass)

are failing on configurations

dartk-tsan-linux-release-x64

15 commits in range, will bisect locally.
Approving to turn bot green.
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Oct 17, 2022
@dcharkes dcharkes self-assigned this Oct 17, 2022
@dcharkes
Copy link
Contributor Author

dcharkes commented Oct 17, 2022 •
edited
Loading

This is caused by the clang roll.
0e2d2e3

@dcharkes dcharkes mentioned this issue Oct 17, 2022
Open
@dcharkes
Copy link
Contributor Author

@mkustermann you've enabled the test in TSAN 5c7e561, any idea why it would timeout before I dive into this?

@dcharkes
Copy link
Contributor Author

cc @rmacnak-google for the clang roll.

copybara-service bot pushed a commit that referenced this issue Oct 17, 2022
@rmacnak-google
[vm] Work around some tests infinite looping on TSAN.
63f957a 
vm/cc/StoreReleaseLoadAcquire
vm/cc/StoreReleaseLoadAcquire1024
began infinite looping after Clang update

TEST=tsan
Bug: #50236
Change-Id: I0472e0cae9723bfa89e11289f8ab24e4174209cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264263
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@dcharkes
Copy link
Contributor Author

Thanks @rmacnak-google !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @rmacnak-google