Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ddc] Temporarily skip tests that are timing out in canary mode #50666

Closed
nshahan opened this issue Dec 8, 2022 · 0 comments
Closed

[ddc] Temporarily skip tests that are timing out in canary mode #50666

nshahan opened this issue Dec 8, 2022 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented Dec 8, 2022

To get better test results into the results database I am temporarily skipping tests that timeout and bring down the test infra while trying to deflake them.

These tests should be enabled again after landing the more of the chain of CLs that enables the new runtime type system in DDC.

lib/async/catch_errors11_test
lib/async/catch_errors12_test
lib/async/catch_errors15_test
lib/async/catch_errors17_test
lib/async/catch_errors20_test
lib/async/catch_errors21_test
lib/async/catch_errors23_test
lib/async/catch_errors24_test
lib/async/catch_errors26_test
lib/async/catch_errors27_test
lib/async/catch_errors5_test
lib/async/catch_errors7_test
lib/async/catch_errors8_test
lib/async/stream_iterator_test
lib/async/stream_zones_test
@nshahan nshahan added P2 A bug or feature request we're likely to work on web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Dec 8, 2022
copybara-service bot pushed a commit that referenced this issue May 11, 2023
@nshahan
[ddc] Temporarily skip tests that timeout
f469856 
These tests are flaky or timing out on the stable DDC configurations.
This change adds skips for the canary configurations to avoid crashing
the infra when too many tests that timeout are attempted to be
deflaked.

When the canary mode stabilizes we should manually mark all these
tests as flaky if they are still not passing on the stable DDC
configurations.

Issue: #50666
Change-Id: I9b1cb8fe466624480767fea05610331bf0f4ed87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302843
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan