Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js-mac-safari flaky tests: unicode-property-invalid_test, mediasource_test , date_time11_test, input_element_datetime_test, and bigint_test #50718

Open
rileyporter opened this issue Dec 14, 2022 · 5 comments
Open

dart2js-mac-safari flaky tests: unicode-property-invalid_test, mediasource_test , date_time11_test, input_element_datetime_test, and bigint_test #50718

rileyporter opened this issue Dec 14, 2022 · 5 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js

Comments

@rileyporter
Copy link
Contributor

The following tests have been flaky since December 13th, 2022 on the dart2js-mac-safari bots:

corelib_2/regexp/unicode-property-invalid_test 
lib_2/html/mediasource_test 
corelib_2/date_time11_test 
lib_2/html/input_element_datetime_test 
lib_2/js/js_util/bigint_test

They were approved failures before they started passing, and have since been flaking several times a day. Sample builds where they started failing: (unicode-property-invalid_test and mediasource_test) and (date_time11_tests, input_element_datetime_test, and bigint_test).
@rileyporter rileyporter added web-dart2js area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Dec 14, 2022
@nshahan
Copy link
Contributor

nshahan commented Dec 16, 2022

Adding to this list:

corelib_2/regexp/unicode-property-char-class_test

@biggs0125
Copy link

Adding another 2 to this list:

corelib_2/local_date_time_test
lib_2/html/input_element_time_test

@nshahan
Copy link
Contributor

nshahan commented Jan 13, 2023

Reapproving these tests flaky status changes again and adding some more tests to this list:

co19_2/LibTest/html/Element/isContentEditable_A02_t01
corelib_2/regexp/unicode-regexp-restricted-syntax_test
lib_2/html/audiocontext_test
lib_2/html/input_element_date_test

@nshahan
Copy link
Contributor

nshahan commented Jan 27, 2023

I'm approving more cycling of the tests listed in this thread between Pass -> RuntimeError today.

Also adding co19_2/LibTest/html/IFrameElement/isContentEditable_A01_t01 to the list.

@Markzipan
Copy link
Contributor

A couple of these have flipped from pass -> Runtime Error.

Also see: #51088

copybara-service bot pushed a commit that referenced this issue Feb 13, 2023
@nshahan
[dart2js, ddc] Skip flaky tests
2d3c9f4 
These tests are flipping between Fail, Pass, Flaky at a rate that
is avoiding flake detection. Skipping until we can address the
issues.

Issue: #51086
Issue: #50718

Change-Id: I9a6aa25bdc1573fe1af8783c7ddb389282695540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282810
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@biggs0125 @nshahan @rileyporter @Markzipan