Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyzer] Implement primitive equality #51046

Closed
eernstg opened this issue Jan 18, 2023 · 6 comments
Closed

[analyzer] Implement primitive equality #51046

eernstg opened this issue Jan 18, 2023 · 6 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone
Dart 3 beta 2

Comments

@eernstg
Copy link
Member

eernstg commented Jan 18, 2023

This is the analyzer specific issue for #51045, which has the details.
@eernstg eernstg added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 18, 2023
@eernstg eernstg mentioned this issue Jan 18, 2023
Closed
@bwilkerson
Copy link
Member

Do we have a timeframe for when this work needs to be done?

@eernstg
Copy link
Member Author

eernstg commented Jan 18, 2023

It's bundled with patterns, cf. dart-lang/language#2108 (comment).

@bwilkerson bwilkerson added this to the Dart 3 beta 2 milestone Jan 18, 2023
@bwilkerson bwilkerson added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jan 18, 2023
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Feb 7, 2023
@scheglov
Copy link
Contributor

What does it mean - "bundled with patterns"? Do we implement this functionality while implementing patterns and report everywhere, or do we report errors for overridden hashCode only when patterns feature is enabled?

@scheglov scheglov self-assigned this Feb 16, 2023
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/283440, but it has some failures, including google3, if enabled unconditionally.

@eernstg
Copy link
Member Author

eernstg commented Feb 16, 2023 •
edited
Loading

🎉
Could you enable it when and only when patterns are enabled? This would imply that the breakage caused by primitive equality would be encountered as part of the migration where patterns are enabled, which is probably a reasonable timing.

copybara-service bot pushed a commit that referenced this issue Feb 18, 2023
@scheglov
Issue 51046. Implement primitive equality.
3f288db 
Bug: #51046
Change-Id: I2190b9e36753cc5f4708597ae0b515430d2f7bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov
Copy link
Contributor

Done, we check presence of get hashCode only if the patterns feature is enabled inside the library where we validate a constant value (where switch is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Dart 3 beta 2
Development

No branches or pull requests
4 participants
@srawlins @scheglov @bwilkerson @eernstg