Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[process] Users unable to follow breaking change process #51801

Open
2 of 3 tasks
itsjustkevin opened this issue Mar 20, 2023 · 6 comments
Open
2 of 3 tasks

[process] Users unable to follow breaking change process #51801

itsjustkevin opened this issue Mar 20, 2023 · 6 comments
Assignees
@itsjustkevin
Labels
area-documentation Prefer using 'type-documentation' and a specific area label.

Comments

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Mar 20, 2023 •
edited
Loading

Problem statement

Users are not able to follow the breaking change process.

Step one of the breaking change process is the announcement. In the current state, users are not able to notify other users that a breaking change is incoming at the email provided (Dart Announce).

Example

Example case: #50710 (comment).

Recommendations
@itsjustkevin
Copy link
Contributor Author

CC: @kevmoo @mit-mit

@mit-mit
Copy link
Member

mit-mit commented Mar 21, 2023

Changing the group setting sgtm, but we should probably expect to need fair bit of moderation/spam. wdyt @athomas ?

@athomas
Copy link
Member

athomas commented Mar 21, 2023

I've updated the group. The spam filters are pretty good and with the volume on dart-misc being low I hope this won't be any higher.

@mit-mit mit-mit added the area-documentation Prefer using 'type-documentation' and a specific area label. label Mar 22, 2023
copybara-service bot pushed a commit that referenced this issue Mar 23, 2023
@itsjustkevin
[Process] Add template for breaking change requests
072c817 
Breaking change requests are currently received in an unstructured way.  To create a more reliable and predictable process, we will use github forms.

This CL creates the form, follow-on CL will update the breaking change documentation.

Issue: #51801

Change-Id: I5ecaa042e3fafdd9d735dd43bccf954aa73e2a2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290605
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
@itsjustkevin
Copy link
Contributor Author

@mit-mit do you know if we have a process for feature requests already?

@mit-mit
Copy link
Member

mit-mit commented Mar 24, 2023

Not a formally written down process, but it's basically just "write up a new issue explaining and motivating the use case".

@itsjustkevin
Copy link
Contributor Author

Thanks, I would like to get this recorded in documentation, I will open a separate issue to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsjustkevin itsjustkevin

Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@itsjustkevin @mit-mit @athomas