Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package:http should be recommended over dart:io's HttpClient #52023

Closed
7 of 8 tasks
brianquinlan opened this issue Mar 7, 2023 · 1 comment
Closed
7 of 8 tasks

package:http should be recommended over dart:io's HttpClient #52023

brianquinlan opened this issue Mar 7, 2023 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io type-documentation A request to add or improve documentation

Comments

@brianquinlan
Copy link
Contributor

brianquinlan commented Mar 7, 2023

Page URL

https://api.dart.dev/stable/2.19.2/dart-io/HttpClient-class.html

Page source

No response

Describe the problem

We want to promote using package:http instead of the HttpClient that is part of dart:io (see the plan)

Expected fix

Ideally we would:

  • Create a better landing package for package:http that:
    • Explains the value of the package
    • Explains how to choose a Client implementation (maybe a feature table for IOClient, cronet_http, cupertino_http, fetch_client etc.)
    • Explain how to configure the Client (per isolate, --dart-define=no_default_http_client=true, etc.)
    • Explains how to use package:http with Flutter (e.g. don't use Network.image)
    • Maybe point to package:dio?
  • Modify the HttpClient page to make it more clear that users should use package:http
  • Remove the reference to HttpClient in the library tour

Additional context

Relevant existing pages:

@atsansone atsansone transferred this issue from dart-lang/site-www Apr 12, 2023
@lrhn lrhn added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io type-documentation A request to add or improve documentation labels Apr 12, 2023
@brianquinlan
Copy link
Contributor Author

I have the outline of some documentation.

Maybe it would make sense to put this in the package:http site somewhere since it cuts across flutter and dart?

@brianquinlan brianquinlan self-assigned this Sep 5, 2023
parlough added a commit to dart-lang/site-www that referenced this issue Dec 11, 2023
…uests stronger (#5391)

Part of dart-lang/sdk#52023
---------

Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
copybara-service bot pushed a commit that referenced this issue Dec 12, 2023
…t directly.

CoreLibraryReviewExempt: documentation-only change
Bug:#52023
Change-Id: I9d4b4bde676f2c85acb95e872fdaf7b5a92c6de5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340283
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
atsansone pushed a commit to atsansone/site-www that referenced this issue Jan 26, 2024
…uests stronger (dart-lang#5391)

Part of dart-lang/sdk#52023
---------

Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

2 participants