pkg/dartdev/test/commands/info_macos_test fails with RuntimeError on pkg-mac-release-arm64

[stereotype441]

There are new test failures on [flow analysis] clean up public methods that call other public methods..

The tests

pkg/dartdev/test/commands/info_macos_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-mac-arm64

Although the blamelist indicates that the test started failing at 214a98e, it's very difficult to imagine a way this commit could have provoked the failure, since the commit is a small refactor to flow analysis, and the failure is related to dartdev's ProcessInfo.commandLine getter returning an unexpectedly trimmed string.

If I had to guess, I suspect some change was made to the configuration of the trybot (e.g. an OS upgrade perhaps) that changed the way the process information appears when querying for processes on a mac.

CC @devoncarew

[devoncarew]

Test failure output:

00:00 �[32m+0�[0m: process listing macos�[0m

00:00 �[32m+0�[0m�[31m -1�[0m: process listing macos �[1m�[31m[E]�[0m�[0m

  Expected: a string starting with 'dart'
    Actual: 'analysis_server.dart.snapshot --suppress-analytics --client-id=dart-fix --disable-server-feature-completion --disable-server-feature-search --sdk <path>/dart-sdk'
  

  package:matcher/src/expect/expect.dart 149:31        fail
  package:matcher/src/expect/expect.dart 144:3         _expect
  package:matcher/src/expect/expect.dart 56:3          expect
  pkg/dartdev/test/commands/info_macos_test.dart 24:9  main.<fn>.<fn>
  package:test_api/src/backend/declarer.dart 215:19    Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7     Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9      Invoker._waitForOutstandingCallbacks.<fn>
  

00:00 �[32m+0�[0m�[31m -1�[0m: process listing parseMacos�[0m

00:00 �[32m+1�[0m�[31m -1�[0m: info macos shows process info�[0m

[sstrickl]

Same test failure as above (log):

stdout:
00:00 �[32m+0�[0m: process listing macos�[0m

00:00 �[32m+0�[0m�[31m -1�[0m: process listing macos �[1m�[31m[E]�[0m�[0m

  Expected: a string starting with 'dart'
    Actual: 'analysis_server.dart.snapshot --suppress-analytics --client-id=dart-fix --disable-server-feature-completion --disable-server-feature-search --sdk <path>/dart-sdk'
  

  package:matcher/src/expect/expect.dart 149:31        fail
  package:matcher/src/expect/expect.dart 144:3         _expect
  package:matcher/src/expect/expect.dart 56:3          expect
  pkg/dartdev/test/commands/info_macos_test.dart 24:9  main.<fn>.<fn>
  package:test_api/src/backend/declarer.dart 215:19    Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7     Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9      Invoker._waitForOutstandingCallbacks.<fn>
  

00:00 �[32m+0�[0m�[31m -1�[0m: process listing parseMacos�[0m

00:00 �[32m+1�[0m�[31m -1�[0m: info macos shows process info�[0m

00:00 �[32m+2�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m

[alexmarkov]

This test started failing once again on the unrelated commit:

--- Command "vm" (took 01.000926s):
DART_CONFIGURATION=ReleaseARM64 CHROME_PATH="/opt/s/w/ir/cache/builder/sdk/third_party/browsers/chrome/Google Chrome.app/Contents/MacOS/Google Chrome" xcodebuild/ReleaseARM64/dart-sdk/bin/dart --enable_asserts --sound-null-safety -Dtest_runner.configuration=unittest-asserts-release-mac-arm64 --ignore-unrecognized-flags --packages=/opt/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json /opt/s/w/ir/cache/builder/sdk/pkg/dartdev/test/commands/info_macos_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: process listing macos�[0m

00:00 �[32m+0�[0m�[31m -1�[0m: process listing macos �[1m�[31m[E]�[0m�[0m

  Expected: a string starting with 'dart'
    Actual: 'analysis_server.dart.snapshot --suppress-analytics --client-id=dart-fix --disable-server-feature-completion --disable-server-feature-search --sdk <path>/dart-sdk'
  

  package:matcher/src/expect/expect.dart 149:31        fail
  package:matcher/src/expect/expect.dart 144:3         _expect
  package:matcher/src/expect/expect.dart 56:3          expect
  pkg/dartdev/test/commands/info_macos_test.dart 24:9  main.<fn>.<fn>
  package:test_api/src/backend/declarer.dart 215:19    Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7     Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9      Invoker._waitForOutstandingCallbacks.<fn>
  

00:00 �[32m+0�[0m�[31m -1�[0m: process listing parseMacos�[0m

00:00 �[32m+1�[0m�[31m -1�[0m: info macos shows process info�[0m

00:00 �[32m+2�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m



Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n unittest-asserts-release-mac-arm64 pkg/dartdev/test/commands/info_macos_test

https://dart-ci.appspot.com/log/pkg-mac-release-arm64/unittest-asserts-release-mac-arm64/8307/pkg/dartdev/test/commands/info_macos_test

[alexmarkov]

/cc @bkonyi

[devoncarew]

Looking at this now -

[joshualitt]

I think I may have also triggered this on a recent commit(https://dart-review.googlesource.com/c/sdk/+/307961). Approving the failure for now.

[nshahan]

This test just started failing again on one of my unrelated changes with the same process listing macos failure shown above.

[aam]

Duplicate of #52658