Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi/invoke_callback_after_suspension_test is flaky #52441

Closed
derekxu16 opened this issue May 18, 2023 · 2 comments
Closed

ffi/invoke_callback_after_suspension_test is flaky #52441

derekxu16 opened this issue May 18, 2023 · 2 comments
Assignees
@mkustermann
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening triaged Issue has been triaged by sub team

Comments

@derekxu16
Copy link
Member

The test was marked as flaky on vm-reload-linux-debug-x64, vm-reload-linux-release-x64, vm-reload-rollback-linux-debug-x64, and vm-reload-rollback-linux-release-x64.

The test was marked as crashing on vm-msan-linux-release-x64: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-msan-linux-release-x64/100/overview

@liamappelbe @mkustermann
@derekxu16 derekxu16 added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening triaged Issue has been triaged by sub team labels May 18, 2023
@mkustermann
Copy link
Member

mkustermann commented May 22, 2023 •
edited
Loading

The test is a newly added regression test for a bug that was fixed in the same CL.

The msan test failure is unrelated: It has to do with the fact that our libc++ isn't msan instrumented, see #44377

The test uses 50 isolates. That means the --hot-reload-test-mode will cause this test to do 50x the number of reloads as a normal single-isolate test. Though I'll investigate a bit more.

@mkustermann
Copy link
Member

Regarding the flaky timeouts: There's a deadlock that can happen in our artificial --hot-reload-test-mode. Will fix in cl/304682

@mkustermann mkustermann self-assigned this May 22, 2023
copybara-service bot pushed a commit that referenced this issue May 22, 2023
@rmacnak-google
[build] Build the standard c++ library from source.
bd589d4 
This allows it to be instrumented by the sanitizers.

Enabled only for MSAN and for Android.

TEST=ci
Bug: #44312
Bug: #44377
Bug: #43075
Bug: #50248
Bug: #50271
Bug: #52441
Change-Id: I96241e6ee28fb2a853d4a113aac268bc415a5fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304147
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
copybara-service bot pushed a commit that referenced this issue May 22, 2023
@rmacnak-google
Revert "[build] Build the standard c++ library from source."
5fde4fb 
This reverts commit bd589d4.

Reason for revert: breaks dart-sdk-linux-riscv64-main

Original change's description:
> [build] Build the standard c++ library from source.
>
> This allows it to be instrumented by the sanitizers.
>
> Enabled only for MSAN and for Android.
>
> TEST=ci
> Bug: #44312
> Bug: #44377
> Bug: #43075
> Bug: #50248
> Bug: #50271
> Bug: #52441
> Change-Id: I96241e6ee28fb2a853d4a113aac268bc415a5fd5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304147
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Daco Harkes <dacoharkes@google.com>

Bug: #44312
Bug: #44377
Bug: #43075
Bug: #50248
Bug: #50271
Bug: #52441
Change-Id: I0b1d0c0da1cd77e0f9645facfc58397cc216c584
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304823
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
copybara-service bot pushed a commit that referenced this issue May 22, 2023
@rmacnak-google
[build] Build the standard c++ library from source.
ddc11f8 
This allows it to be instrumented by the sanitizers.

Enabled only for MSAN and for Android.

Don't pick up Flutter's including no_exceptions in the default config set.

TEST=ci
Bug: #44312
Bug: #44377
Bug: #43075
Bug: #50248
Bug: #50271
Bug: #52441
Change-Id: If01704ff29569fba8f8181ed31d52faba8d8370f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304824
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derekxu16 @mkustermann