Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer_plugin should support analyzer v6.0.0 #52769

Closed
rrousselGit opened this issue Jun 23, 2023 · 2 comments
Closed

Analyzer_plugin should support analyzer v6.0.0 #52769

rrousselGit opened this issue Jun 23, 2023 · 2 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task

Comments

@rrousselGit
Copy link

Analyzer is now at version 6.0.0, but analyzer_plugin uses ^5.0.0

@lrhn lrhn added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jun 23, 2023
@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task labels Jun 30, 2023
@srawlins srawlins self-assigned this Jul 31, 2023
copybara-service bot pushed a commit that referenced this issue Aug 2, 2023
My plan is to checkout the SDK when analyzer 6.0.0 was published,
then cherry-pick this commit, and publish analyzer_plugin.

In a test run, the package analyzes cleanly and all tests pass.

Bug: #52769
Change-Id: I10661dd665c612eeb82977bdf2f8432e022044b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@srawlins
Copy link
Member

srawlins commented Aug 3, 2023

Thanks for pointing this out, @rrousselGit . Just published analyzer_plugin 0.11.3.

@srawlins srawlins closed this as completed Aug 3, 2023
@rrousselGit
Copy link
Author

Epic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task
Projects
None yet
Development

No branches or pull requests

3 participants