FFI regression on macOS affecting package:sqlite3

[simolus3]

This snippet works with Dart 3.1.5 (stable), but crashes under the latest Dart Beta (3.2.0-210.4.beta) and Dev Builds (3.3.0-65.0.dev)

import 'dart:io';

import 'package:sqlite3/sqlite3.dart';

void main() {
  final db = sqlite3.openInMemory();
  db.createFunction(
    functionName: 'dart_version',
    function: (args) => Platform.version,
  );
  print(db.select('SELECT dart_version()'));
  db.dispose();
}

To reproduce this:

git clone https://github.com/simolus3/sqlite3.dart.git -b repro-macos-issue --depth 1
dart pub get
dart run example/main.dart 
zsh: killed     dart run example/main.dart

I'm running macOS 14.0 on ARM. The stack trace and error code makes it seem like this might be related to flutter/flutter#136980. If it matters, that version of the sqlite3 package is using Pointer.fromFunction to implement callbacks, not NativeCallables.

Crashed Thread:        10  DartWorker

Exception Type:        EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))
Exception Codes:       UNKNOWN_0x32 at 0x0000000103043a90
Exception Codes:       0x0000000000000032, 0x0000000103043a90

Termination Reason:    Namespace CODESIGNING, Code 2 Invalid Page

[...]

Thread 10 Crashed:: DartWorker
0   ???                           	       0x103043a90 ???
1   libsqlite3.dylib              	       0x193dda594 sqlite3_step + 996
2   ???                           	       0x103107a28 ???
3   ???                           	       0x103956ec4 ???
4   ???                           	       0x10395695c ???
5   ???                           	       0x1039567c4 ???
6   ???                           	       0x103956674 ???
7   ???                           	       0x103955f0c ???
8   ???                           	       0x103953728 ???
9   ???                           	       0x103953404 ???
10  ???                           	       0x10394cc60 ???
11  ???                           	       0x10392e3d8 ???
12  ???                           	       0x10392e27c ???
13  ???                           	       0x10392e158 ???
14  ???                           	       0x10392c9a8 ???
15  ???                           	       0x10392c600 ???
16  ???                           	       0x10392b0e8 ???
17  ???                           	       0x103103404 ???
18  dart                          	       0x1009f183c 0x10088c000 + 1464380
19  dart                          	       0x1009f32f4 0x10088c000 + 1471220
20  dart                          	       0x100a10be4 0x10088c000 + 1592292
21  dart                          	       0x100a33830 0x10088c000 + 1734704
22  dart                          	       0x100a33e5c 0x10088c000 + 1736284
23  dart                          	       0x100b3bed0 0x10088c000 + 2817744
24  dart                          	       0x100b3c148 0x10088c000 + 2818376
25  dart                          	       0x100ac64a0 0x10088c000 + 2335904
26  libsystem_pthread.dylib       	       0x18d11b034 _pthread_start + 136
27  libsystem_pthread.dylib       	       0x18d115e3c thread_start + 8

[mraleph]

Yeah, we overlooked this. Fix: https://dart-review.googlesource.com/c/sdk/+/333260

@athomas is it possible to setup a bot which runs tests using signed SDK on Mac?

[athomas]

@mraleph Possible, yes. But we currently have nothing like it. We'd need:

• Sign SDK builds on main.
• Ensure that test.py works for the relevant testing using an SDK distribution.
• Setup a new builder that downloads a signed SDK instead of building it and then runs tests.
• Trigger that builder from the SDK builder (or as a cron job).

[dcharkes]

@mraleph I assume we want a cherry pick for this?

[mraleph]

I will let it cook a bit while I am changing build files to make it possible to run tests on our bots. But yep - I will also file a cherry pick request for it.

[mraleph]

@athomas I have an alternative proposal. I have massaged GN rules to produce signed binaries using the identity supplied in through a GN arg. We should be able to use - identity to produce ad-hoc signed binaries. I am doing CQ run now to see if this is good enough. If it is - then we can change our bots to build with DART_GN_ARGS='codesigning_identity="-"' and that should cover our testing needs.

[dcharkes]

I will let it cook a bit while I am changing build files to make it possible to run tests on our bots. But yep - I will also file a cherry pick request for it.

@mraleph Friendly bump so this doesn't fall through the cracks.

[mraleph]

CP request filed.