Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion suggestions in string interpolation shouldn't include void expressions #54682

Closed
parlough opened this issue Jan 20, 2024 · 0 comments
Assignees
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@parlough
Copy link
Member

parlough commented Jan 20, 2024

void main() {
  print('Test: ${ot^}');
}

void other() { }

Results in:

void main() {
  print('Test: ${other()}');
}

other should either not be suggested here, or if it is, it should generate a tear off. But I think it's rare to want to include a tear off in a string, so it's probably fine to just not suggest it.

Tested on current main: cb16f98

Reproduced with IJ and VSCode.

Doesn't affect 3.2 stable, where the void function is not suggested at all.

@parlough parlough added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-completion Issues with the analysis server's code completion feature analyzer-server labels Jan 20, 2024
@bwilkerson bwilkerson self-assigned this Jan 23, 2024
copybara-service bot pushed a commit that referenced this issue Jan 23, 2024
Bug: #54682
Change-Id: I03a7fc0dc6f914b65775c84124b963929a9813bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347980
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

2 participants