Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] DevTools 2.31.1 #54834

Closed
kenzieschmoll opened this issue Feb 6, 2024 · 3 comments
Closed

[CP] DevTools 2.31.1 #54834

kenzieschmoll opened this issue Feb 6, 2024 · 3 comments
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@kenzieschmoll
Copy link
Contributor

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/350349

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/350349

Issue Description

Includes critical fixes for the Deep Links tool that is targeting the February Dart / Flutter stable release.

What is the fix

Includes critical fixes for the Deep Links tool that is targeting the February Dart / Flutter stable release (currently still on beta, which is why this CP issue says the CP is targeting the beta branch)

Why cherry-pick

The Deep Links tool is shipping for the first time with the upcoming stable, and we need to provide a robust and polished first experience.

Risk

low

Issue link(s)

none

Extra Info

The commits that are included with this cherry-pick release are here: flutter/devtools@v2.31.0...2.31.1

@kenzieschmoll kenzieschmoll added the cherry-pick-review Issue that need cherry pick triage to approve label Feb 6, 2024
@itsjustkevin
Copy link
Contributor

@mit-mit can you take a look at this cherry pick request and the associated CL?

@devoncarew devoncarew added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. and removed area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). labels Feb 6, 2024
@jacob314
Copy link
Member

jacob314 commented Feb 6, 2024

I agree this cherrypick is worth landing.

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Feb 6, 2024
copybara-service bot pushed a commit that referenced this issue Feb 6, 2024
Bug: #54834
Cherry-pick: flutter/devtools@v2.31.0...2.31.1
Cherry-pick-request: #54834
Fixes: #54834
Change-Id: I5fde1d9d42f9aaaa37cdf3f928c7456c876d2c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350349
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
@vsmenon
Copy link
Member

vsmenon commented Feb 7, 2024

lgtm

copybara-service bot pushed a commit that referenced this issue Feb 12, 2024
This was originally cherry-picked into beta: https://dart-review.googlesource.com/c/sdk/+/350349. However, there was an issue that occurred during branch alignment that requires this CP to now be cherry-picked into the stable branch.

During branch alignment, dev was merged to beta, which overwrote the intended beta branch. This mistake required the stable build to be built from the last hotfixed beta, which excluded the original cherry-pick.

Bug: #54834
Cherry-pick: flutter/devtools@v2.31.0...2.31.1
Cherry-pick-request: #54834
Fixes: #54834
Change-Id: I3268b3787db8d6ed4284e67795d4d8c5adfb8331
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352042
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Development

No branches or pull requests

8 participants