[CP] Ensure CpuInfo Windows flag detection works, doesn't crash on pre-sse41 cpus #55211
Comments
|
SGTM |
mit-mit
added
the
area-meta
itsjustkevin
added
cherry-pick-approved
|
@aam this CL is still showing errors on both beta and stable. Are these expected? |
|
@itsjustkevin yeah, errors are unrelated and are expected: one set of failures are due to #55212 that recently affected infra, another - due to #55212 which is caused test failures due to transition from PST to PDT. |
|
Thanks @aam please go ahead and submit if that is the case. |
BUG=flutter/flutter#140138 BUG=flutter/flutter#138784 BUG=flutter/flutter#138693 TEST=manually on win x64 with `__ int3();` added in front of `roundsd` and forced `CpuId::sse41=false;` Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/357218 Cherry-pick-request: #55211 Change-Id: I90a60d4972c5183d43516c628b68a71b7cc76912 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357983 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
BUG=flutter/flutter#140138 BUG=flutter/flutter#138784 BUG=flutter/flutter#138693 TEST=manually on win x64 with `__ int3();` added in front of `roundsd` and forced `CpuId::sse41=false;` Change-Id: I9e2dbf2615549dcc7c979036b5442276c2e0fb29 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/357218 Cherry-pick-request: #55211 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/358040 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
|
Submitted. |
itsjustkevin
added
cherry-pick-merged
|
This issue seems to be back in Flutter 3.22.X. Anyone else experiencing this? Reverting back to 3.19.6 resolves it again. |
|
@FifoTheHein if you’re seeing an issue, please open a new one. We do not review closed issues when triaging. |
|
@FifoTheHein If you create a new issue, could you please post a link to it here? If this issue is really back (I hope not), I would like to subscribe to it ;) Thanks! |
Commit(s) to merge
c5946a1
Target
both
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/357983
https://dart-review.googlesource.com/c/sdk/+/358040
Issue Description
CPU detection wasn't working correctly on Windows, caused crashes of dart and flutter apps when running on older pre-sse41 cpus.
What is the fix
Ensure information about detected cpu features is properly used on Windows.
Why cherry-pick
Fix flutter and dart crashes for Windows users who also use older machines.
Risk
low
Issue link(s)
flutter/flutter#140138, flutter/flutter#138784, flutter/flutter#138693
Extra Info
No response
The text was updated successfully, but these errors were encountered: