Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyzer] augment library syntax is not supported #55374

Closed
sgrekhov opened this issue Apr 4, 2024 · 1 comment
Closed

[analyzer] augment library syntax is not supported #55374

sgrekhov opened this issue Apr 4, 2024 · 1 comment
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Apr 4, 2024

For augmented libraries syntax was changed from library augment... to augment library.... But this new syntax is not supported by analyzer (nor by CFE as well) and produces COMPILE_TIME_ERROR.IMPORT_OF_NOT_AUGMENTATION
@sgrekhov sgrekhov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature labels Apr 4, 2024
@srawlins srawlins added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Apr 5, 2024
@srawlins
Copy link
Member

srawlins commented Apr 5, 2024

@scheglov

@a-siva a-siva mentioned this issue Apr 5, 2024
Open
@scheglov scheglov self-assigned this Apr 6, 2024
copybara-service bot pushed a commit that referenced this issue Apr 8, 2024
@scheglov
Parse 'augment library' instead of 'library augment'.
d0e4ef7 
Bug: #55374

Change-Id: I856c21f4b102fa589f5a14c3d28daf64e4112099
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@scheglov scheglov closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-macros Implementation of the macros feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
Static Metaprogramming - design/prototype
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @scheglov @sgrekhov