Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declaredIndentifier typos in Dart Language Specification, Draft Version 0.01, October 10th, 2011 #7

Closed
DartBot opened this issue Oct 10, 2011 · 5 comments
Closed

declaredIndentifier typos in Dart Language Specification, Draft Version 0.01, October 10th, 2011 #7

DartBot opened this issue Oct 10, 2011 · 5 comments
Assignees
@gbracha

Comments

@DartBot
Copy link

DartBot commented Oct 10, 2011

This issue was originally filed by adrian.ai...@gmail.com

What steps will reproduce the problem?

  1. Open http://www.dartlang.org/docs/spec/dartLangSpec.pdf
  2. Search for "indent" (without the quotes)
  3. Notice how this should rather read ident instead.

What is the expected output? What do you see instead?

I see what must be a typo.

What version of the product are you using? On what operating system?

Dart Programming Language Specification
Draft Version 0.01
The Dart Team
October 10th, 2011

Please provide any additional information below.

Here is a copy/paste from the pdf (with the fi ligature manually reapaired). See my (sic) annotations for where I think the typos are:

11.9

Try

The try statement supports the definition of exception handling code in a struc-
tured way.

tryStatement:
try block (catchPart+ finallyPart? | finallyPart)
;

catchPart:
catch ‘(’ declaredIndentifier (sic) (‘, ’ declaredIndentifier (sic))? ‘)’ block
;

finallyPart:
finally block
;
@iposva-google
Copy link
Contributor

Set owner to @gbracha.

@DartBot
Copy link
Author

DartBot commented Oct 11, 2011

This comment was originally written by drfibonacci@google.com

Removed the owner.
Added Component-Docs, Accepted labels.

@DartBot
Copy link
Author

DartBot commented Oct 11, 2011

This comment was originally written by drfibonacci@google.com

Set owner to @kwalrath.

@kwalrath
Copy link
Contributor

Back to Gilad, who can reassign to me once he has a new PDF ready.

Set owner to @gbracha.

@gbracha
Copy link
Contributor

gbracha commented Oct 12, 2011

Added Done label.

@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Open
@kasperl kasperl mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@crelier crelier mentioned this issue Jun 3, 2015
Closed
@andersjohnsen andersjohnsen mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@whesse whesse mentioned this issue Jun 3, 2015
Closed
@sigmundch sigmundch mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@johnpryan johnpryan mentioned this issue Oct 10, 2023
Closed
@mboyanna mboyanna mentioned this issue Dec 7, 2023
Closed
@cosminbodnariuc cosminbodnariuc mentioned this issue Dec 7, 2023
Closed
@derekxu16 derekxu16 mentioned this issue Dec 18, 2023
Closed
This was referenced Jan 18, 2024
Closed
Closed
@mnts mnts mentioned this issue Feb 6, 2024
Open
@itsjustkevin itsjustkevin mentioned this issue Feb 27, 2024
Open
@JgomesAT JgomesAT mentioned this issue Feb 28, 2024
Closed
@bvversoz bvversoz mentioned this issue Mar 5, 2024
Open
@adityasaxen adityasaxen mentioned this issue Mar 14, 2024
Closed
@upasana-khatiwada upasana-khatiwada mentioned this issue Mar 16, 2024
Closed
@Reinoal Reinoal mentioned this issue Mar 18, 2024
Closed
@butterbrain butterbrain mentioned this issue Apr 4, 2024
Closed
@abhisiroha abhisiroha mentioned this issue Apr 24, 2024
Closed
@eernstg eernstg mentioned this issue Jul 1, 2024
Open
@majornuts majornuts mentioned this issue Jul 4, 2024
Closed
@Lootwig Lootwig mentioned this issue Jul 18, 2024
Open
@the-mrinal the-mrinal mentioned this issue Jul 31, 2024
Open
@aam aam mentioned this issue Jul 31, 2024
Closed
@ailabs-software ailabs-software mentioned this issue Aug 6, 2024
Closed
@thermoworker thermoworker mentioned this issue Aug 12, 2024
Open
@theaquaflower theaquaflower mentioned this issue Aug 15, 2024
Closed
@724898928 724898928 mentioned this issue Sep 4, 2024
Open
@SwederSchellens SwederSchellens mentioned this issue Sep 24, 2024
Closed
@mjablecnik mjablecnik mentioned this issue Sep 27, 2024
Open
@ChaserVasya ChaserVasya mentioned this issue Oct 20, 2024
Open
copybara-service bot pushed a commit that referenced this issue Oct 22, 2024
@pq
[element model] fix unsafe ConstructorMember cast
f65f719 
See: b/374689139.

https://dart-review.googlesource.com/c/sdk/+/390941 is blocking an SDK roll.

Root cause:


```
Action threw an exception: type 'ConstructorMember' is not a subtype of type 'ConstructorFragment' in type cast
#0      InterfaceTypeImpl.constructors2.<anonymous closure> (package:analyzer/src/dart/element/type.dart:569)
#1      MappedListIterable.elementAt (dart:_internal/iterable.dart:435)
#2      ListIterator.moveNext (dart:_internal/iterable.dart:364)
#3      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:150)
#5      new List.of (dart:core-patch/array_patch.dart:39)
#6      ListIterable.toList (dart:_internal/iterable.dart:224)
#7      InterfaceTypeImpl.constructors2 (package:analyzer/src/dart/element/type.dart:570)
#8      _Visitor._hasConstConstructorInvocation (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:110)
#9      _Visitor.visitConstructorDeclaration (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:58)
```


To verify the fix locally:

```
  solo_test_X() async {
    await assertNoErrorsInCode(r'''
class A<T> {}
''');

    var A = findElement.class_('A').instantiate(
      typeArguments: [intType],
      nullabilitySuffix: NullabilitySuffix.none,
    );
    A.constructors2;
  }
```


Bug: b/374689139
Change-Id: I70034d938d840dc0c3939db27e7116164e4617e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391483
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Open
@MLDenzzl MLDenzzl mentioned this issue Oct 28, 2024
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwalrath @gbracha @iposva-google @DartBot