Fix Homebrew undent warning #32346
Closed
Fix Homebrew undent warning #32346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Feb 28, 2018
Update the generated `dart.rb` formula file to fix: ``` Warning: Calling <<-EOS.undent is deprecated! Use <<~EOS instead. /usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats' Please report this to the dart-lang/dart tap! ``` being reported by `brew`.
|
FYI: queued up! https://dart-review.googlesource.com/c/sdk/+/44100 |
athomas
pushed a commit
to dart-lang/homebrew-dart
that referenced
this pull request
Jun 4, 2021
Update the generated `dart.rb` formula file to fix: ``` Warning: Calling <<-EOS.undent is deprecated! Use <<~EOS instead. /usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats' Please report this to the dart-lang/dart tap! ``` being reported by `brew`. Fixes #48 Credit for original patch to @fsouza: https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4 Closes #32346 dart-lang/sdk#32346 GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71 Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e Reviewed-on: https://dart-review.googlesource.com/44100 Reviewed-by: Kevin Moore <kevmoo@google.com> Reviewed-by: William Hesse <whesse@google.com>
athomas
pushed a commit
to dart-lang/homebrew-dart
that referenced
this pull request
Jul 1, 2021
Update the generated `dart.rb` formula file to fix: ``` Warning: Calling <<-EOS.undent is deprecated! Use <<~EOS instead. /usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats' Please report this to the dart-lang/dart tap! ``` being reported by `brew`. Fixes #48 Credit for original patch to @fsouza: https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4 Closes #32346 dart-lang/sdk#32346 GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71 Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e Reviewed-on: https://dart-review.googlesource.com/44100 Reviewed-by: Kevin Moore <kevmoo@google.com> Reviewed-by: William Hesse <whesse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the generated
dart.rbformula file to fix:being reported by
brew.Fixes dart-lang/homebrew-dart#48
Credit for original patch to @fsouza:
https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4