Support homebrew on Linux #38512
Closed
Support homebrew on Linux #38512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Actual review will happen on https://dart-review.googlesource.com/c/sdk/+/118376 after which this PR will be closed. |
|
FYI, I left some comments on https://dart-review.googlesource.com/c/sdk/+/118376, once they are addressed, I will merge this change and all future releases will be published for Linux as well. |
|
Hi @sestegra thanks for contributing, did you have a chance to look at the code review comments? |
|
@mit-mit Update done |
athomas
reviewed
Oct 7, 2019
athomas
pushed a commit
to dart-lang/homebrew-dart
that referenced
this pull request
Jun 4, 2021
Fix #42 Closes #38512 dart-lang/sdk#38512 GitOrigin-RevId: 561d002a18d95b97f217904f0f024c71fad0cb3d Change-Id: I6ab2ef15e4220d641848bec15a12d9b64e375cb5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118376 Reviewed-by: Alexander Thomas <athom@google.com>
athomas
pushed a commit
to dart-lang/homebrew-dart
that referenced
this pull request
Jul 1, 2021
Fix #42 Closes #38512 dart-lang/sdk#38512 GitOrigin-RevId: 561d002a18d95b97f217904f0f024c71fad0cb3d Change-Id: I6ab2ef15e4220d641848bec15a12d9b64e375cb5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118376 Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dart-lang/homebrew-dart#42