Implement RawSocket.readMessage/writeMessage. #46481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
force-pushed
the
socket-send-recv-msg
branch
2 times, most recently
from
ecbf42e
to
36618c1
Compare
robert-ancell
force-pushed
the
socket-send-recv-msg
branch
from
36618c1
to
ddba51f
Compare
|
Review will happen on the corresponding Gerrit CL https://dart-review.googlesource.com/c/sdk/+/205067 |
There is not a current use case for this, and it can be added back later if necessary.
|
Looks like the gerrit review for this is now https://dart-review.googlesource.com/c/sdk/+/212036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46328
Some notes on the implementation:
RawSocketand notSocket, since when receiving a message you need to decide if usingrecvorrecvmsg.