Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANTLR] Transform recursive definition of onParts to use iteration ... #51744

Closed
wants to merge 1 commit into from

Conversation

modulovalue
Copy link
Contributor

... to match the language spec.

@copybara-service
Copy link

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/288980

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/288980 has been updated with the latest commits from this pull request.

copybara-service bot pushed a commit that referenced this pull request Apr 17, 2023
Follow-up to SDK issue #51744.

Change-Id: Ic713ed5adf99bed49f1e93a70817650d5f0c3c46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295545
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
@eernstg
Copy link
Member

eernstg commented Apr 18, 2023

Oops, the comments here aren't transferred to the Gerrit CL, and I didn't see the reference to the language specification here, so there was no need for me to worry about making a lot of small changes to the language specification.

Anyway, it's done now. Thanks for noticing this discrepancy!

@modulovalue modulovalue deleted the on-parts branch May 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants