Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain surrounding comments in remove comparison quickfix for if-statement #52544

Closed
wants to merge 8 commits into from
Closed

Retain surrounding comments in remove comparison quickfix for if-statement #52544

wants to merge 8 commits into from

Conversation

shilangyu
Copy link
Contributor

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

fixes #44102

@copybara-service

This comment was marked as off-topic.

@copybara-service
Copy link

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/306220

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

6 similar comments
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/306220 has been updated with the latest commits from this pull request.

@devoncarew devoncarew requested a review from scheglov June 21, 2023 21:25
@devoncarew
Copy link
Member

Looks like there is one remaining comment over at the Gerrit CL (https://dart-review.googlesource.com/c/sdk/+/306220).

Assigning a reviewer to this PR to remove the PR from our triage queue (the review should still take place on the gerrit CL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the 'remove comparison' quick fix removes too much text
2 participants