Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'appsize' url to correct 'app-size' - Fixes #54724 #54725

Closed
wants to merge 1 commit into from

Conversation

timmaffett
Copy link
Contributor

This PR fixes #54724

It changes the 'appsize' in the url to the correct 'app-size' that the devtools server expects.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/348187

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@vsmenon vsmenon requested a review from bkonyi January 28, 2024 15:03
@parlough
Copy link
Member

Nice catch and fix :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart devtools --appSizeBase opens incorrect 'appsize' URL in devtools, instead of 'app-size'
2 participants