Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSP. #54781

Closed
wants to merge 1 commit into from
Closed

Add DSP. #54781

wants to merge 1 commit into from

Conversation

modulovalue
Copy link
Contributor

Fixes #54540.

Other changes:

  • There's a new FAQ section that describes how to generate parsers.
  • I've dedented the custom code because ANTLR adds its own indentation to generated parsers.

Also, just so that we don't forget this, it would be great to maintain the git history of Dart.g, i.e., if Dart.g is removed, it might be better to replace it with the contents of Dart.g4 in this PR instead of just removing Dart.g and keeping this Dart.g4.

Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/349408

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@devoncarew
Copy link
Member

@eernstg - it looks like you've started the review in https://dart-review.googlesource.com/c/sdk/+/349408. If it looks good, I believe you'll need a 2nd reviewer to lgtm it.

@devoncarew devoncarew removed the request for review from eernstg February 5, 2024 15:11
Copy link

https://dart-review.googlesource.com/c/sdk/+/349408 has been updated with the latest commits from this pull request.

@copybara-service copybara-service bot closed this in e8b20f6 Feb 6, 2024
@eernstg
Copy link
Member

eernstg commented Feb 6, 2024

Hi @devoncarew, thanks for taking a look at this! I actually landed the CL without problems. So now we just need a newer ANTLR on all systems. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ANTLR] Migrating from Java actions to Dart actions.
3 participants