Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nullsafety #493

Closed
vanlooverenkoen opened this issue Nov 22, 2020 · 7 comments · Fixed by #520
Closed

Add support for nullsafety #493

vanlooverenkoen opened this issue Nov 22, 2020 · 7 comments · Fixed by #520
Labels
status-blocked Blocked from making progress by another (referenced) issue

Comments

@vanlooverenkoen
Copy link

I am upgrading my package (Kiwi) gbtb16/kiwi#51

But it seems that source_gen is not yet migrated to support nullsafety. Is there a timeline on when this could be added?

@jakemac53
Copy link
Contributor

This will be blocked on package:build, which is blocked on package:analyzer

@vanlooverenkoen
Copy link
Author

Blocked because of: dart-lang/build#2920

@kevmoo
Copy link
Member

kevmoo commented Feb 26, 2021

I believe this has been fixed!

@kevmoo kevmoo closed this as completed Feb 26, 2021
@kevmoo
Copy link
Member

kevmoo commented Feb 26, 2021

@vanlooverenkoen – do you want (1) the code in source_gen to be null safe? Or (2) just to support generating null-safe code?

We have (2) done, not (1).

@vanlooverenkoen
Copy link
Author

I want the code in code_gen to be nullsafe

@kevmoo kevmoo reopened this Feb 26, 2021
@kevmoo kevmoo added the status-blocked Blocked from making progress by another (referenced) issue label Feb 26, 2021
@kevmoo
Copy link
Member

kevmoo commented Feb 26, 2021

We need to get all of the downstream packages migrated, first.

You can still USE source_gen to generate null-safe code.

json_serializable does this now!

@simolus3
Copy link
Contributor

simolus3 commented Mar 2, 2021

After 2.0 of build is released, we'd still be blocked by dart_style (and build_verify not supporting build 2.x, but that's not relevant now).

Apart from that, I'm happy to migrate this package as well if no-one is working on it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
4 participants