Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nullability #51

Closed
vanlooverenkoen opened this issue Oct 2, 2020 · 8 comments · Fixed by #69
Closed

Add support for nullability #51

vanlooverenkoen opened this issue Oct 2, 2020 · 8 comments · Fixed by #69
Assignees
@vanlooverenkoen
Labels
feature New feature or request kiwi generator kiwi_generator package kiwi kiwi package refactor Code optimization in general

Comments

@vanlooverenkoen
Copy link
Collaborator

#49 does not yet support nullability.

With the testing/stable release closing for nullability, we need to make sure kiwi supports nullability as well
@vanlooverenkoen vanlooverenkoen added feature New feature or request kiwi kiwi package kiwi generator kiwi_generator package refactor Code optimization in general nullability labels Oct 2, 2020
@vanlooverenkoen vanlooverenkoen self-assigned this Oct 2, 2020
@vanlooverenkoen vanlooverenkoen mentioned this issue Nov 21, 2020
Closed
@vanlooverenkoen
Copy link
Collaborator Author

@Yegorisa I will take a look at it tomorrow

vanlooverenkoen added a commit that referenced this issue Nov 22, 2020
@vanlooverenkoen
#51: Added the basic migration to support nullability for kiwi (no su…
b0d0664 
…pport yet for the kiwi_generator)
@vanlooverenkoen vanlooverenkoen mentioned this issue Nov 22, 2020
Closed
@vanlooverenkoen
Copy link
Collaborator Author

vanlooverenkoen commented Nov 22, 2020 •
edited
Loading

I have already migrated the kiwi package to support nullability. (In it's most basic form, just migrated to support nullsafety) the kiwi_generator has some dependencies that are not yet supporting nullsafety so for that one I will still wait.

Check out the code here: https://github.com/vanlooverenkoen/kiwi/tree/feature/%2351-nullsafety

This was referenced Nov 22, 2020
Closed
Closed
@vanlooverenkoen vanlooverenkoen pinned this issue Nov 22, 2020
@vanlooverenkoen vanlooverenkoen mentioned this issue Nov 23, 2020
Closed
@vanlooverenkoen
Copy link
Collaborator Author

@Yegorisa Since we are blocked because of the dart-lang packages. Do you think it would be nice to already have a kiwi-nullsafety.0 release? This release will not work with the kiwi_genrator.

@vanlooverenkoen vanlooverenkoen mentioned this issue Nov 23, 2020
Closed
@Yegorisa
Copy link

@vanlooverenkoen since I am using the Kiwi with the kiwi_generator, I would prefer to wait for until dart sdk will migrate and then migrate kiwi_generator

@vanlooverenkoen
Copy link
Collaborator Author

I think that is the best idea as well. To bad that all these dart packages still need to be migrated

@behnamsattar
Copy link

Null safety is out with Flutter 2.0 and this needs to be addressed ASAP.

@vanlooverenkoen
Copy link
Collaborator Author

vanlooverenkoen commented Mar 3, 2021 •
edited
Loading

I was still waiting on the nullsafe support for some dependencies for the kiwi generator. As stated before kiwi is already migrated. You can use it via git right now

vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
#51: added nullsafety support for the generator. (but dependencies ar…
fb94167 
…e not ready yet)
vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
#51: Added a fix to the kiwi_generator that
768ea74
@vanlooverenkoen vanlooverenkoen mentioned this issue Mar 4, 2021
Closed
@vanlooverenkoen
Copy link
Collaborator Author

@Yegorisa @behnamsattar I have created a pull request with the fixes for null safety. Because I was hoping the generator could be migrated to null safety as wel. I will create a dev release today for kiwi & the generator.

Please file new issues when you are having trouble.

vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
b14c68a 
…i-generator

# Conflicts:
#	kiwi_generator/pubspec.yaml
vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
7420b2b 
…i-generator
vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
f96d163 
…i-generator

# Conflicts:
#	kiwi_generator/lib/src/kiwi_injector_generator.dart
vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
3fe054e 
…i-generator
vanlooverenkoen added a commit that referenced this issue Mar 4, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
d97a7a3 
…i-generator
vanlooverenkoen added a commit that referenced this issue Mar 16, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
df4219b 
…i-generator

# Conflicts:
#	kiwi_generator/pubspec.yaml
vanlooverenkoen added a commit that referenced this issue Mar 16, 2021
@vanlooverenkoen
#51: Updated dependencies
a7b9c20
vanlooverenkoen added a commit that referenced this issue Mar 16, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
2bb8a3e 
…i-generator

# Conflicts:
#	kiwi_generator/lib/src/kiwi_injector_generator.dart
vanlooverenkoen added a commit that referenced this issue Mar 19, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
e52e8ae 
…i-generator

# Conflicts:
#	kiwi_generator/CHANGELOG.md
vanlooverenkoen added a commit that referenced this issue Mar 19, 2021
@vanlooverenkoen
#51 Updated dependencies. & fixed a breaking issue with the kiwi cont…
8bd46ab 
…ainer resolve
vanlooverenkoen added a commit that referenced this issue Mar 19, 2021
@vanlooverenkoen
Merge branch 'feature/#51-nullsafety' into feature/#51-nullsafety-kiw…
ed44223 
…i-generator
vanlooverenkoen added a commit that referenced this issue Jun 1, 2021
@vanlooverenkoen
#51: Updated all latest versions to fully support nullsafety
73b20b7
@vanlooverenkoen vanlooverenkoen mentioned this issue Jun 1, 2021
Merged
vanlooverenkoen added a commit that referenced this issue Jun 1, 2021
@vanlooverenkoen
#51: Fixed tests
b784a1b
vanlooverenkoen added a commit that referenced this issue Jun 1, 2021
@vanlooverenkoen
Merge pull request #69 from vanlooverenkoen/feature/#51-nullsafety-ki…
f4498a5 
…wi-generator

Feature/#51 nullsafety kiwi generator
@gbtb16 gbtb16 unpinned this issue Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanlooverenkoen vanlooverenkoen

Labels
feature New feature or request kiwi generator kiwi_generator package kiwi kiwi package refactor Code optimization in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#51 nullsafety kiwi generator gbtb16/kiwi
Feature/#51 nullsafety gbtb16/kiwi
3 participants
@vanlooverenkoen @Yegorisa @behnamsattar