Skip to content

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented Jan 30, 2023

Save 4 characters of typing millions of times. The line will not read as
nicely in many situations, but it doesn't make a significant difference.

The shorter name, with no capital letters, also draws the least possible
attention to this name, which carries the least information of any part
of the expression.

Save 4 characters of typing millions of types. The line will not read as
nicely in many situations, but it doesn't make a significant difference.
- **Breaking** `checkThat` renamed to `check`.
- Added an example.
- Include a stack trace in the failure description for unexpected errors from
Futures or Streams. >>>>>>> master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Futures or Streams. >>>>>>> master
Futures or Streams.

@natebosch natebosch marked this pull request as ready for review February 2, 2023 22:42
@natebosch
Copy link
Member Author

Out of the discussion that has happened I think I've seen more voices in support of check than any alternative I've explored. I will land this.

@natebosch natebosch merged commit d2858ba into master Feb 2, 2023
@natebosch natebosch deleted the checkThat-to-check branch February 2, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants