Skip to content

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 7, 2023

Closes out issues:

These extra user properties were provided by package:usage for flutter/flutter's legacy analytics.

The constructor will look like the below

// Development constructor points to dev GA4 instance; not
// to be used in production
final Analytics analytics = Analytics.development(
  tool: DashTool.flutterTool,
  flutterChannel: 'ey-test-channel',
  flutterVersion: 'Flutter 3.6.0-7.0.pre.47',
  clientIde: 'VSCode',
  dartVersion: 'Dart 2.19.0',
  // This can be set to true while testing to validate
  // against GA4 usage limitations (character limits, etc.)
  enableAsserts: false,
);

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Nov 7, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.3.0 ready to publish unified_analytics-v5.3.0
package:graphs 2.3.2-wip WIP (no publish necessary)
package:cli_config 0.1.2 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@eliasyishak
Copy link
Contributor Author

@bwilkerson I know the analysis server is already sending clientId in the event constructors... this PR isn't suggesting you need to change that, but you can add it to the Analytics constructor so that each event will contain the IDE being used

@eliasyishak eliasyishak merged commit d898ad1 into dart-lang:main Nov 8, 2023
@eliasyishak eliasyishak deleted the 188-add-host-os-version-and-language-as-user-properties branch November 8, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants