-
Notifications
You must be signed in to change notification settings - Fork 73
Update CODEOWNERS #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #2177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CODEOWNERS
file to change the owner for package:markdown
. The change is straightforward, replacing the previous team owners with a new individual owner. The modification is correct and aligns with the pull request's stated goal. I have no further comments.
pkgs/test_reflective_loader @scheglov | ||
pkgs/timing @dart-lang/dart-bat | ||
pkgs/unified_analytics @bkonyi @dart-lang/dash-developer-services | ||
pkgs/watcher @dart-lang/dart-ecosystem-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please point pkgs/watcher at me + dart-model-team per the recent discussion?
Or I can send a PR, as you prefer. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind sending a PR, that would be great (I just edit this file in the github UI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep yep #2179
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
cc @srawlins, @davidmorgan
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.