Skip to content

Conversation

mraleph
Copy link
Member

@mraleph mraleph commented Sep 30, 2025

Directory.list() can fail with the same error due to concurrent file system modifications.

Suppress this error uniformly across the code base.

Directory.list() can fail with the same error
due to concurrent file system modifications.

Suppress this error uniformly across the code
base.
@mraleph
Copy link
Member Author

mraleph commented Sep 30, 2025

@davidmorgan the test I added revealed more races, so I suppressed these errors everywhere.

Any opinion if I should add something to CHANGELOG.md here?

@mraleph mraleph marked this pull request as ready for review September 30, 2025 08:53
@mraleph mraleph requested review from a team and davidmorgan as code owners September 30, 2025 08:53
Copy link

github-actions bot commented Sep 30, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
watcher None 1.1.3 1.1.4-wip 1.1.3 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/watcher/lib/src/directory_watcher/linux.dart 💚 91 % ⬆️ 1 %
pkgs/watcher/lib/src/directory_watcher/mac_os.dart 💔 0 % ⬇️ NaN %
pkgs/watcher/lib/src/directory_watcher/polling.dart 💔 83 % ⬇️ 9 %
pkgs/watcher/lib/src/directory_watcher/windows.dart 💔 0 % ⬇️ NaN %
pkgs/watcher/lib/src/utils.dart 💔 83 % ⬇️ 17 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@davidmorgan
Copy link
Contributor

Thanks!

I guess, update the previously-added CHANGELOG entry to apply to remove "on Linux".

It looks like there is also an "access denied" exception on Windows

https://github.com/dart-lang/tools/actions/runs/18124334834/job/51576024573?pr=2183
test\directory_watcher\polling_test.dart: subdirectories subdirectory watching is robust against races (failed)
PathAccessException: Directory listing failed, path = 'C:\Users\runneradmin\AppData\Local\Temp\dart_test_c7c634fd\dir483*' (OS Error: Access is denied.
, errno = 5)

and another error, not sure if related to these changes

test\ready\windows_test.dart: ready completes even if directory does not exist (failed)
FileSystemException: Error in FileSystemEntity.identicalSync (OS Error: The system cannot find the path specified.
, errno = 3)
dart:io

@davidmorgan
Copy link
Contributor

This one I do know is a pre-existing issue on MacOS

test/file_watcher/native_test.dart: emits a remove event when the watched file is moved away (failed)
Expected: should emit an event that is remove file.txt
Actual: <Instance of 'StreamQueue'>
Which: emitted • modify /private/var/folders/q0/wmf37v850txck86cpnvwm_zw0000gn/T/dart_test_DScFbJ/file.txt

still the access error on Windows though.

@mraleph
Copy link
Member Author

mraleph commented Sep 30, 2025

I suppressed PathAccessException as well. PTAL

Copy link
Contributor

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mraleph mraleph merged commit 08515a4 into dart-lang:main Sep 30, 2025
18 checks passed
@mraleph mraleph deleted the more-robustness branch September 30, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants