-
Notifications
You must be signed in to change notification settings - Fork 71
Prepare to release watcher 1.1.4 #2184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the watcher
package for its 1.1.4
release. The changes correctly update the version from 1.1.4-wip
to 1.1.4
in CHANGELOG.md
and pubspec.yaml
. The changes are appropriate for a release.
As a process improvement, please remember to fill out the pull request description to summarize the changes and their purpose, and to mark the contributor guide as reviewed. This helps maintain a clear and searchable history of changes for the project.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
@davidmorgan I want to publish 1.1.4 and then I will update DEPS (I am not sure if there is some special procedure if followed to rev version in DEPS?). |
I'm currently working on another fix, what do you think about waiting for this one too? From what Nate said I think the process to publish is
|
On second thought, more bug fix releases seems better--easier to figure out what broke if something breaks :) so let's not wait for my fix. |
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.