-
Notifications
You must be signed in to change notification settings - Fork 71
Fix flaky test on Windows. #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a flaky test on Windows by replacing a fixed delay with a more robust polling loop. The change is a good improvement for the test's reliability. I have one suggestion to refactor the new polling loop to improve its readability and maintainability by using named constants and a for
loop.
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
Reran the tests a few times, no sign of the flake this was intended to fix; there is a different flake related to timeout, I will start a different PR for that :) thanks! |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/669b15f..ec2a4fe): ec2a4fee 2025-10-06 dependabot[bot] Bump test_reflective_loader from 0.2.3 to 0.4.0 (dart-lang/dartdoc#4111) 2ec3e4ef 2025-10-02 Konstantin Scheglov Stop using TypeDefiningElement. (dart-lang/dartdoc#4112) f65c7e21 2025-10-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/dartdoc#4113) ecosystem (https://github.com/dart-lang/ecosystem/compare/36e514d..96ee861): 96ee861 2025-10-02 Devon Carew misc repo metadata updates (dart-lang/ecosystem#372) 0d7ffaa 2025-10-02 Moritz Rename comments (dart-lang/ecosystem#373) a3cf960 2025-10-01 dependabot[bot] Bump the github-actions group with 5 updates (dart-lang/ecosystem#374) test (https://github.com/dart-lang/test/compare/a16f149..8083c8f): 8083c8f2 2025-10-03 Nate Bosch Make all package:coverage imports conditional (dart-lang/test#2544) tools (https://github.com/dart-lang/tools/compare/ce9d2ad..6866f9b): 6866f9b1 2025-10-06 Morgan :) Allow more time for tests on Windows. (dart-lang/tools#2193) 1264445e 2025-10-06 Morgan :) Fix flaky test on Windows. (dart-lang/tools#2192) webdev (https://github.com/dart-lang/webdev/compare/0b2a408..29ba1b1): 29ba1b12 2025-10-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/webdev#2693) Change-Id: I9582b0380b2b974a2d05ab4f77c67c14e92aaa63 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453580 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
No description provided.