Force quit frontend server after one second, unskip tests #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I still see at least one timeout here. Probably this needs some investigation on a windows box. |
|
I tried running the test that timed out locally and the whole thing completed in 2.5 seconds. So I do not believe it is timing out it is actually hanging. Trying to figure out why, but I can't reproduce it locally. |
|
Ahah! It appears to actually be hanging on the cleanup of the client (ie: in the |
jakemac53
changed the title
annagrin
approved these changes
Aug 19, 2021
| @@ -295,10 +295,13 @@ class FrontendServerClient { | |||
| } | |||
|
|
|||
| /// Stop the service gracefully (using the shutdown command) | |||
| Future<int> shutdown() { | |||
| _feServerStdoutLines.cancel(); | |||
| Future<int> shutdown() async { | |||
There was a problem hiding this comment.
It would be great to open a bug on the SDK for that!
natebosch
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1386
Fixes #1383