Skip to content

Fix crash when sending events to client.js during hot restart #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Fix crash when sending events to client.js during hot restart #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a81561
Fix race condition causing crash when sending events to client.js dur…
Mar 9, 2022
a293316
Fix tests
Mar 9, 2022
078e24c
Removed stray solo
Mar 9, 2022
e3695d1
Addressed CR comments
Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
- Fix an issue in reporting DevTools stats where the DevTools load time was
not always recorded.
- Add an `ide` query parameter to the Dart DevTools URL for analytics.
- Fix a race where injected client crashed on events send just before hot
restart.

**Breaking changes:**
- `Dwds.start` and `ExpressionCompilerService` now take
Expand Down
Loading