Migrate extension_debugger_test, dart_uri_test, and location_test to null-safety
#1703
Conversation
| @@ -153,7 +153,7 @@ class ExtensionDebugger implements RemoteDebugger { | |||
|
|
|||
| @override | |||
| void close() => _closed ??= () { | |||
| _closeController.add(WipEvent({})); | |||
| _closeController.add({}); | |||
There was a problem hiding this comment.
The content of this event does not matter, its existence is used to notify clients that the connection should be closed. Using a WipEvent caused a type error, since WipEvent expects non-null parameters.
dwds/test/location_test.dart
Outdated
| @@ -189,9 +187,9 @@ class MockLoadStrategy implements LoadStrategy { | |||
|
|
|||
| @override | |||
| shelf.Handler get handler => | |||
| (request) => (request.url.path == 'someDummyPath') | |||
| (request) async => (request.url.path == 'someDummyPath') | |||
There was a problem hiding this comment.
Looks like MockLoadStrategy is very similar to the FakeStrategy in fakes.dart - should we unify this code?
dwds/test/location_test.dart
Outdated
| ? shelf.Response.ok('some dummy response') | ||
| : null; | ||
| : shelf.Response.notFound('not found'); |
There was a problem hiding this comment.
moduleForServerPath returns a Future<String?> in the base interface - should we make it the same here, to flush any compilation errors?
| @@ -164,7 +162,7 @@ void main() { | |||
|
|
|||
| tearDownAll(() async { | |||
| DartUri.clear(); | |||
| await outputDir?.delete(recursive: true); | |||
| await outputDir.delete(recursive: true); | |||
There was a problem hiding this comment.
Not sure if this matters but this will prevent retries if the creation of outputDir fails, but previously retries would be technically possible.
There was a problem hiding this comment.
Leaving for now, we can update if needed
No description provided.