Pre-warm expression compiler to speed up Flutter Inspector page loading. #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 9, 2022 17:59
…agrin/webdev into annagrin/prewarm-expression-compiler
annagrin
commented
Dec 3, 2022
elliette
reviewed
Dec 3, 2022
elliette
reviewed
Dec 3, 2022
elliette
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate an expression in widget_inspector library on isolate start to pre-warm the flutter framework module cache in the expression compiler.
Flutter inspector relies on evaluations in widget_inspector library, which is a part of the flutter framework module, to produce widget trees, draw the layout explorer, show hover cards etc. Pre-warming the cache while DevTools is still loading helps Flutter Inspector start faster.
Related: dart-lang/sdk#49944 (pre-warming will have speedup effect after this change is propagated to callers of dwds that use expression compiler worker)
Closes: #1768