Skip to content

Can save storage objects in both session and local storage #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2022
Merged

Can save storage objects in both session and local storage #1807

merged 2 commits into from
Dec 2, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Dec 1, 2022

  • DebugInfo for an app is saved in session storage, so it does not persist across sessions
  • DevToolsOpener setting is saved in local storage, so it persists across sessions

See https://developer.chrome.com/docs/extensions/reference/storage/#type-StorageArea for details on session vs local storage

@elliette elliette requested a review from annagrin December 1, 2022 19:15
elliette added a commit to elliette/webdev that referenced this pull request Dec 2, 2022
@elliette
[WIP] Need dart-lang#1807 merged first
9206fac
annagrin
annagrin approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 9b19b3b into dart-lang:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin