Refactor puppeteer tests to use Worker type
#1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
approved these changes
Dec 5, 2022
|
|
||
| // Note: The following delay is required to reduce flakiness. It makes | ||
| // sure the service worker execution context is ready. | ||
| Future<void> workerEvalDelay() async { |
There was a problem hiding this comment.
A question - is there a way to detect when the extension is ready, so we can avoid potentially waiting too little?
There was a problem hiding this comment.
Unfortunately not! Same answer as #1791 (comment), I haven't found a way to determine whether or not this will flake. We could add retry logic and add the delay before the retry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Workertype is now visible inpackage:puppeteer(xvrh/puppeteer-dart#198)This PR refactors to the Puppeteer tests to remove some code duplication now that we have access to the
Workertype.