Skip to content

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Dec 6, 2022

Fixes the following error when running the extension test locally:

  Evaluation failed: TypeError: Cannot read properties of undefined (reading 'windowId')
      at __puppeteer_evaluation_script__:3:18
  package:puppeteer/src/page/execution_context.dart 169:11  ExecutionContext._evaluateInternal
  ===== asynchronous gap ===========================
  package:puppeteer/src/page/execution_context.dart 76:20   ExecutionContext.evaluate
  ===== asynchronous gap ===========================
  test/puppeteer/extension_test.dart 239:11                 _getWindowId
  ===== asynchronous gap ===========================
  test/puppeteer/extension_test.dart 167:30                 main.<fn>.<fn>.<fn>

@elliette elliette requested a review from annagrin December 6, 2022 21:43
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit c164231 into dart-lang:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants