Skip to content

Prepare DWDS 16.0.2 for hotfix into Flutter to fix flutter_tools crash #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jan 5, 2023

Fix Flutter tools crash: Bad state: Future already completed

Fixes flutter/flutter#117676

See explanation flutter/flutter#117676 (comment).

@elliette elliette requested a review from annagrin January 6, 2023 00:35
@elliette
Copy link
Contributor Author

elliette commented Jan 6, 2023

Failing test is expected, it was fixed in a later PR (#1835) than the point in commit history that we are applying this fix

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott!

@elliette elliette merged commit 44b39a9 into dart-lang:hotfix-dwds-v.16.0.1 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants