Skip to content

[MV3 Debug Extension] Fix isDevMode getter #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

[MV3 Debug Extension] Fix isDevMode getter #1962

merged 1 commit into from
Feb 15, 2023

Conversation

elliette
Copy link
Contributor

  • Turns isDevMode into a getter
  • Make sure it caches the value before returning

@elliette elliette requested a review from annagrin February 14, 2023 23:32
annagrin
annagrin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit c77043e into dart-lang:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin