Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MV3 Debug Extension] Remove isMv3Extension field from DevToolsRequest #1963

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

elliette
Copy link
Contributor

This field isn't actually necessary, the query parameter gets overwritten by the extension.

@elliette elliette changed the title [MV3 Extension] Remove isMv3Extension field from DevToolsRequest [MV3 Debug Extension] Remove isMv3Extension field from DevToolsRequest Feb 14, 2023
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 3ad544e into dart-lang:master Feb 15, 2023
elliette added a commit to elliette/webdev that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants