Skip to content

[MV3 Debug Extension] User can reload app and continue to debug #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2023
Merged

[MV3 Debug Extension] User can reload app and continue to debug #1968

merged 6 commits into from
Feb 17, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 16, 2023 •
edited
Loading

Fixes a few edge cases where debugging from the embedded Chrome Devtools panel would fail.

A user can now:

  1. start, stop, and start debugging again from the Chrome DevTools panel
  2. replace the app that is being debugged with a new app, and start debugging that new app instead

Added a test case for 1), need to first modify TestContext and TestServer before I can add a test case for 2).

@elliette elliette marked this pull request as ready for review February 16, 2023 22:28
@elliette elliette requested a review from annagrin February 16, 2023 22:28
annagrin
annagrin approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small request

@elliette elliette merged commit cd66172 into dart-lang:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin